[Bug 705993] aiffparse: fix push mode / add tests

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=705993
  GStreamer | gst-plugins-bad | git

--- Comment #9 from Matthieu Bouron <matthieu.bouron at collabora.com> 2013-08-15 14:04:43 UTC ---
(In reply to comment #4)
> Review of attachment 251615 [details]:
> 
> ::: tests/check/elements/aiffparse.c
> @@ +54,3 @@
> +      NULL);
> +
> +  fail_unless (gst_caps_is_always_compatible (caps, tcaps));
> 
> gst_caps_can_intersect() should be enough here :)

Fixed in new patch.

> 
> @@ +147,3 @@
> +    GstBuffer ** buffer)
> +{
> +  if (offset + length > sizeof (aiff_file))
> 
> This could still be a short read, i.e. if offset < sizeof(aiff_file)

Fixed in new patch.

> 
> ::: tests/check/elements/aiffparse.h
> @@ +2,3 @@
> +#include <glib.h>
> +
> +static const guint8 aiff_file[] = {
> 
> Maybe put this into a separate binary file instead of a large header?

It felt more convenient to place into a large header. Anyway, should the file
be placed under the tests/files/ directory ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.