[Bug 706091] New: [srtpdec] Shadowed variable causes buffers to be dropped

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=706091
  GStreamer | gst-plugins-bad | 1.1.3

           Summary: [srtpdec] Shadowed variable causes buffers to be
                    dropped
    Classification: Platform
           Product: GStreamer
           Version: 1.1.3
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: gstblub at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=251774)
 View: https://bugzilla.gnome.org/attachment.cgi?id=251774
 Review: https://bugzilla.gnome.org/review?bug=706091&attachment=251774

Patch that fixes the bug

A shadowed variable in request_key_with_signal() causes the return value to
always be NULL, which causes buffers to be dropped:

0:00:13.564041677 28969  0x82459b0 DEBUG                srtpdec
gstsrtpdec.c:448:signal_get_srtp_params:<srtpdec0> Caps received
0:00:13.564167462 28969  0x82459b0 DEBUG                srtpdec
gstsrtpdec.c:422:get_stream_from_caps: Got key [0xb390de48]
0:00:13.564234299 28969  0x82459b0 INFO                 srtpdec
gstsrtpdec.c:469:init_session_stream:<srtpdec0> Setting RTP policy...
0:00:13.564273772 28969  0x82459b0 INFO                 srtpdec
gstsrtpdec.c:472:init_session_stream:<srtpdec0> Setting RTCP policy...
0:00:13.564348414 28969  0x82459b0 DEBUG                srtpdec
gstsrtpdec.c:620:request_key_with_signal:<srtpdec0> New stream set with SSRC
2138354990
0:00:13.564398213 28969  0x82459b0 WARN                 srtpdec
gstsrtpdec.c:854:gst_srtp_dec_chain:<srtpdec0> Invalid buffer, dropping
0:00:13.564437928 28969  0x82459b0 WARN                 srtpdec
gstsrtpdec.c:930:gst_srtp_dec_chain:<srtpdec0:rtcp_sink> Dropping buffer
0:00:14.358516438 28969  0x8245a30 WARN                basesink
gstbasesink.c:3264:gst_base_sink_chain_unlocked:<rtpout> warning: Internal data
flow problem.
0:00:14.358592719 28969  0x8245a30 WARN                basesink
gstbasesink.c:3264:gst_base_sink_chain_unlocked:<rtpout> warning: Received
buffer without a new-segment. Assuming timestamps start from 0.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.