[Bug 705999] taglist: handle publisher, interpreted-by and key tags

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=705999
  GStreamer | gstreamer (core) | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #251721|none                        |needs-work
             status|                            |

--- Comment #11 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-08-16 07:43:59 UTC ---
Review of attachment 251721:
 --> (https://bugzilla.gnome.org/review?bug=705999&attachment=251721)

::: gst-libs/gst/tag/tag.h
@@ +85,3 @@
+ * GST_TAG_MUSICAL_KEY:
+ *
+ * Musical key in which the sound starts. It is represented as a string

Should it be the key in which the song (sound?) starts or the main key of the
song?

@@ +88,3 @@
+ * with a maximum length of three characters. The ground keys are
+ * represented with "A","B","C","D","E", "F" and "G" and halfkeys
+ * represented with "b" and "#". Minor is represented as "m" (e.g. "Dbm" $00).

What's the %00 here? :)

@@ +89,3 @@
+ * represented with "A","B","C","D","E", "F" and "G" and halfkeys
+ * represented with "b" and "#". Minor is represented as "m" (e.g. "Dbm" $00).
+ * Off key is represented with an "o" only.

What about non-major/minor keys? Keys that are not on any of the half keys but
between? Thinking about non-western music here.

@@ +90,3 @@
+ * represented with "b" and "#". Minor is represented as "m" (e.g. "Dbm" $00).
+ * Off key is represented with an "o" only.
+ */

Add Since: 1.2 marker her

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.