[Bug 705999] taglist: handle publisher, interpreted-by and key tags

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=705999
  GStreamer | gstreamer (core) | git

--- Comment #17 from Matthieu Bouron <matthieu.bouron at collabora.com> 2013-08-16 09:42:21 UTC ---
(In reply to comment #11)
> Review of attachment 251721 [details]:
> 
> ::: gst-libs/gst/tag/tag.h
> @@ +85,3 @@
> + * GST_TAG_MUSICAL_KEY:
> + *
> + * Musical key in which the sound starts. It is represented as a string
> 
> Should it be the key in which the song (sound?) starts or the main key of the
> song?
> 
> @@ +88,3 @@
> + * with a maximum length of three characters. The ground keys are
> + * represented with "A","B","C","D","E", "F" and "G" and halfkeys
> + * represented with "b" and "#". Minor is represented as "m" (e.g. "Dbm" $00).
> 
> What's the %00 here? :)

Null byte as specified in the id3 documentation, I guess i should not mention
it.

> 
> @@ +89,3 @@
> + * represented with "A","B","C","D","E", "F" and "G" and halfkeys
> + * represented with "b" and "#". Minor is represented as "m" (e.g. "Dbm" $00).
> + * Off key is represented with an "o" only.
> 
> What about non-major/minor keys? Keys that are not on any of the half keys but
> between? Thinking about non-western music here.
> 
> @@ +90,3 @@
> + * represented with "b" and "#". Minor is represented as "m" (e.g. "Dbm" $00).
> + * Off key is represented with an "o" only.
> + */
> 
> Add Since: 1.2 marker her

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.