[Bug 706278] different sinkpad's caps handling in Funnel

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=706278
  GStreamer | gstreamer (core) | git

Olivier Crete (Tester) <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #252169|none                        |rejected
             status|                            |

--- Comment #2 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2013-08-19 01:34:10 UTC ---
Review of attachment 252169:
 --> (https://bugzilla.gnome.org/review?bug=706278&attachment=252169)

::: plugins/elements/gstfunnel.c
@@ +286,3 @@
   if (funnel->last_sinkpad != pad) {
     gst_object_replace ((GstObject **) & funnel->last_sinkpad,
         GST_OBJECT (pad));

These lines here and the one below should already do what you want. If the
buffer comes from a pad different than the last, it should push out the sticky
event from this pad, including the caps. Anyway, having a property for this is
just wrong, the sticky events (including the caps, stream-start, segment, tags,
etc) should always match the buffer being pushed out.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.