[Bug 705832] eglglesink: support window handle changes in PAUSED

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Aug 19 04:27:34 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=705832
  GStreamer | gst-plugins-bad | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #252193|none                        |needs-work
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-08-19 11:27:29 UTC ---
Review of attachment 252193:
 --> (https://bugzilla.gnome.org/review?bug=705832&attachment=252193)

::: ext/eglgles/gsteglglessink.c
@@ +505,3 @@
   eglBindAPI (EGL_OPENGL_ES_API);

+  g_mutex_lock (&eglglessink->render_lock);

Did you test this? ;) The loop of this thread is a few lines below, so this
code would only ever be executed right after the thread was started

@@ +965,3 @@

+  g_mutex_lock (&eglglessink->render_lock);
+  eglglessink->force_full_reconf = TRUE;

You should probably add some object to the queue to wake up the rendering
thread and trigger reconfiguration

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list