[Bug 701681] [regression] NASA HLS stream

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=701681
  GStreamer | gst-plugins-bad | git

--- Comment #30 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2013-08-19 12:04:58 UTC ---
(In reply to comment #28)
> Created an attachment (id=252199)
 View: https://bugzilla.gnome.org/attachment.cgi?id=252199
 Review: https://bugzilla.gnome.org/review?bug=701681&attachment=252199

> fix for segfault from uninitialized uri
> 
> Adding uri=NULL fixes a segfault when playing this stream:
> http://184.72.239.149/vod/smil:bigbuckbunnyiphone.smil/playlist.m3u8
>
>
> The call to gst_query_parse_uri_redirection assumes that the URI
> parameter is always set, but if there is a case when this
> assumption does not hold true. See gst/gstquery.c:
>
> g_return_if_fail (GST_QUERY_TYPE (query) == GST_QUERY_URI);

If this g_return_if_fail() is triggered, all bets are off really. It is a
programming mistake when that happens. Having said that, I don't mind
initialising the uri to NULL, I think it's a good precaution, but I disagree
that it's worth fixing because the g_return_if_fail() could happen..

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.