[Bug 704760] opencv: disparity-map calculation element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=704760
  GStreamer | gst-plugins-bad | 1.x

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #252234|none                        |needs-work
             status|                            |

--- Comment #15 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-08-19 15:13:36 UTC ---
Review of attachment 252234:
 --> (https://bugzilla.gnome.org/review?bug=704760&attachment=252234)

::: ext/opencv/gstdisparity.cpp
@@ +480,2 @@
   if (fs->flushing)
     return GST_FLOW_FLUSHING;

Return without unlocking the mutex

@@ +517,2 @@
   if (fs->flushing)
     return GST_FLOW_FLUSHING;

Return without unlocking the mutex

@@ +601,2 @@
   GST_DEBUG_OBJECT (pad, " right has finished");
+  gst_buffer_unmap (fs->buffer_left, &info);

You must not unref the buffer in chain_left, but unref it here after unmapping

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.