[Bug 679941] No permissions / sanity checks when trying to use formatter save functions

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=679941
  GStreamer | gst-editing-services | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #252277|none                        |needs-work
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-08-20 07:47:47 UTC ---
Review of attachment 252277:
 --> (https://bugzilla.gnome.org/review?bug=679941&attachment=252277)

::: ges/ges-formatter.c
@@ +303,3 @@
+
+    if (dir == NULL)
+      return FALSE;

You're leaking "file" here

@@ +312,3 @@
+    GST_ERROR ("Unable to write to directory: %s", (*error)->message);
+
+    return FALSE;

And here "file" and "dir"

@@ +318,3 @@
+    if (!writeable) {
+      GST_ERROR ("Unable to write to directory");
+      return FALSE;

And here "file", "dir" and "info"

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.