[Bug 705452] regression: h264parse: Does not extract width/height/etc from h264-in-mpeg-ps

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=705452
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #252371|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-08-20 11:51:42 UTC ---
Review of attachment 252371:
 --> (https://bugzilla.gnome.org/review?bug=705452&attachment=252371)

::: gst/videoparsers/gsth264parse.c
@@ +1888,3 @@
+    /* do not set CAPS before SPS/PPS nals parsing */
+    if (!h264parse->have_sps || !h264parse->have_pps)
+      return TRUE;

I'm not sure if that is enough, also it would seem cleaner to just put the
negotiate block below in an if (have_sps && have_pps) block.

The problem I see here is that handle_frame() will immediately call negotiate()
again, which might be before the SPS/PPS are parsed.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.