[Bug 706441] New: videomixer: Rework/review the way we handle flushing

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Aug 20 13:09:13 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=706441
  GStreamer | gst-plugins-good | 1.x

           Summary: videomixer: Rework/review the way we handle flushing
    Classification: Platform
           Product: GStreamer
           Version: 1.x
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: thibault.saunier at collabora.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


We have been quite a few issue with the current implementation of the flush
handling in videomixer (most of those also apply to adder btw) and we should
review it and rework it once for all instead of keeping adding stuff around to
fix issues as they come if needed.

Currently we have the following code:

 * When getting a flushing seek, we set flush_stop_pending=TRUE which means
that the next time collectpad->collected is called, we send a flush_stop
ourself before pushing a buffer.

  * When we get a flush_start, we set waiting_flush_stop and we forward the
flush_stop once and set that variable back to FALSE.

Also there is a bug where we send 2 times flush_stop Mathieu Duponchelle has a
patch for it.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list