[Bug 704808] Split GstGLDisplay into that and GstGLContext

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=704808
  GStreamer | gst-plugins-gl | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #252500|none                        |needs-work
             status|                            |

--- Comment #10 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-08-21 06:44:48 UTC ---
Review of attachment 252500:
 --> (https://bugzilla.gnome.org/review?bug=704808&attachment=252500)

::: gst-libs/gst/gl/gstglcontext.h
@@ +1,3 @@
+/*
+ * GStreamer
+ * Copyright (C) 2012 Matthew Waters <ystreet00 at gmail.com>

We have 2013 ;)

@@ +54,3 @@
+
+  /*< public >*/
+//  GMutex        lock;

Why the commented out mutex?

@@ +90,3 @@
+GstGLAPI      gst_gl_context_get_gl_api       (GstGLContext *context);
+
+gboolean      gst_gl_context_create           (GstGLContext *context, guintptr
external_gl_context, GError ** error);

This is what creates the window? Better name it create_window() then. Or is it
initialization the context? Then better call it initialize() or something like
that

::: gst-libs/gst/gl/gstgldisplay.h
@@ +61,3 @@
   GstGLAPI              gl_api;

   GstGLFuncs           *gl_vtable;

Didn't we say that the vtable, etc should be per context? And I assume there
could be multiple contexts per display connection, so we should allow that.
E.g. you could want to share the display with the complete pipeline, but have
multiple contexts running in differents threads

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.