[Bug 704808] Split GstGLDisplay into that and GstGLContext

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=704808
  GStreamer | gst-plugins-gl | git

--- Comment #12 from Matthew Waters <ystreet00 at gmail.com> 2013-08-21 07:49:03 UTC ---
(In reply to comment #10)
> Review of attachment 252500 [details]:
> 
> ::: gst-libs/gst/gl/gstglcontext.h
> @@ +1,3 @@
> +/*
> + * GStreamer
> + * Copyright (C) 2012 Matthew Waters <ystreet00 at gmail.com>
> 
> We have 2013 ;)

Doh.

> @@ +54,3 @@
> +
> +  /*< public >*/
> +//  GMutex        lock;
> 
> Why the commented out mutex?

Taken from GstGLWindow, thought I might need it.  It was removed in the next
patch.

> @@ +90,3 @@
> +GstGLAPI      gst_gl_context_get_gl_api       (GstGLContext *context);
> +
> +gboolean      gst_gl_context_create           (GstGLContext *context, guintptr
> external_gl_context, GError ** error);
> 
> This is what creates the window? Better name it create_window() then. Or is it
> initialization the context? Then better call it initialize() or something like
> that

In the end, creates the context.  In this patch, it just calls the window
vfunc.  The next patch moves code so that GstGLContext takes control of that
(and other) aspects of the GL context.  Creating the actual window is done
within GstGLWindow (as a result of calling _create). TBH I don't think it
really matters whether it's called create or initialize.

> ::: gst-libs/gst/gl/gstgldisplay.h
> @@ +61,3 @@
>    GstGLAPI              gl_api;
> 
>    GstGLFuncs           *gl_vtable;
> 
> Didn't we say that the vtable, etc should be per context? And I assume there
> could be multiple contexts per display connection, so we should allow that.
> E.g. you could want to share the display with the complete pipeline, but have
> multiple contexts running in differents threads

Yes and yes.  It's up next ;) (probably as part of #704809).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.