[Bug 704760] opencv: disparity-map calculation element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=704760
  GStreamer | gst-plugins-bad | 1.x

--- Comment #17 from Miguel (elmiguelao) Casas-Sanchez <miguelecasassanchez at gmail.com> 2013-08-22 07:41:55 UTC ---
(In reply to comment #15)
> Review of attachment 252234 [details]:
> 
> ::: ext/opencv/gstdisparity.cpp
> @@ +480,2 @@
>    if (fs->flushing)
>      return GST_FLOW_FLUSHING;
> 
> Return without unlocking the mutex
> 
> @@ +517,2 @@
>    if (fs->flushing)
>      return GST_FLOW_FLUSHING;
> 
> Return without unlocking the mutex
> 
> @@ +601,2 @@
>    GST_DEBUG_OBJECT (pad, " right has finished");
> +  gst_buffer_unmap (fs->buffer_left, &info);
> 
> You must not unref the buffer in chain_left, but unref it here after unmapping

Got it! - done those 3

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.