[Bug 607342] patch that Add 2 news plugins jp462bayer and bayer2rgb2

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sat Aug 24 15:09:05 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=607342
  GStreamer | gst-plugins-bad | git

--- Comment #36 from David Schleef <ds at schleef.org> 2013-08-24 22:08:56 UTC ---
Nearly approved, pending resolution on caps:

+    GST_STATIC_CAPS ("video/x-bayer,format=(string){bggr,grbg,gbrg,rggb},"
+       
"width=(int)[1,MAX],height=(int)[1,MAX],framerate=(fraction)[0/1,MAX];"
+        "video/x-bayer,format=(string){bggr16,grbg16,gbrg16,rggb16},"
+        "bpp=(int){10,12,14,16},endianness={1234,4321},width=(int)[1,MAX],"
+        "height=(int)[1,MAX],framerate=(fraction)[0/1,MAX]")

In the time since this patch was first created, we switched to using format to
indicate endianness in audio/x-raw and video/x-raw.  I think should be changed
to match.

In addition, I'd like to see the following things cleaned up in a follow up
patch:

+  /* half-pattern is not allowed */
+  g_assert (bayer2rgb->width % 2 == 0);

This should be a negotiation failure, not assertion.

+#define DEFAULT_MODE GST_BAYER2RGB_MODE_BILINEAR

(nitpick) This is called "method" in other places.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list