[Bug 706054] move GstEGLImageBufferPool and allocator from eglglessink to gstegl lib

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=706054
  GStreamer | gst-plugins-bad | git

--- Comment #6 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-08-26 08:07:05 UTC ---
(In reply to comment #4)
> > ::: gst-libs/gst/egl/Makefile.am
> > @@ +20,3 @@
> >      $(GST_LIBS) \
> > +    $(EGL_LIBS) \
> > +    $(EGLGLES_LIBS)
> > 
> > This now makes the egl library depend on GL or GLES, that's not how it was
> > intended
> 
> Yes sure but how to deal with glGenTextures/glBindTexture/glTexImage2D calls
> before the eglCreateImageKHR call then ?

That would be done by the callback that is passed to the pool, no?

> > @@ +42,3 @@
> > +
> > +gboolean gst_gl_got_error (const char *wtf);
> > +gboolean gst_egl_got_error (const char *wtf);
> > 
> > These should not be public
> 
> why ? if we want to use it in eglglessink as well

Because they're internal helper functions and not really pretty for general
usage.

> > @@ +90,3 @@
> > +EGLint gst_egl_display_get_major (GstEGLDisplay * display);
> > +EGLint gst_egl_display_get_minor (GstEGLDisplay * display);
> > +void gst_egl_display_set_version (GstEGLDisplay * display, EGLint major,
> > EGLint minor);
> > 
> > Shouldn't the display get the version from itself, instead of having the user
> > supply it?
> 
> ok so I should move the call to eglInitialise to gstegl lib:
> 
> So it's like replacing gst_egl_display_set_version by:
> 
> gboolean gst_egl_display_initialize (GstEGLDisplay * display)
> [...]
> 
> ?

I guess so

> Actually every call to egl should go progressively to gstegl lib.

That's not really the goal of that library, we don't want to create
GObject-like bindings for EGL. It should just contain whatever is necessary to
allow EGLImage usage between different elements in GStreamer pipelines. These
elements can use EGL and GL/GLES themselves.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.