[Bug 706779] oggmux: support flushing seeks

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Aug 26 01:45:18 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=706779
  GStreamer | gst-plugins-base | git

--- Comment #3 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-08-26 08:45:15 UTC ---
(In reply to comment #2)

> > 2) FLUSH_STOP aggregation is done by forwarding the first FLUSH_STOP and then
> > ignoring the others. That's what videomixer does but what if this case happens:
> > one upstream sends FLUSH_STOP; another upstream sends more data belonging to
> > the old segment; the other upstream finally sends FLUSH_STOP. Isn't this racy?
> 
> I think you should wait until all FLUSH_START of all upstreams are received.
> After that you can safely forward the very first FLUSH_STOP. Any data that is
> sent from upstream before the FLUSH_STOP is dropped because the pads are
> flushing.

Actually the waiting shouldn't even be necessary. It should just be ensured
that collectpads drop data from all pads as soon as the flushing seek is
received (or possibly when the first FLUSH_START is received on any pad). See
bug #706441

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list