[Bug 706054] move GstEGLImageBufferPool and allocator from eglglessink to gstegl lib

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=706054
  GStreamer | gst-plugins-bad | git

--- Comment #8 from Julien Isorce <julien.isorce at gmail.com> 2013-08-26 09:46:34 UTC ---
(In reply to comment #7)
> Review of attachment 252934 [details]:
> 
> ::: gst-libs/gst/egl/egl.h
> @@ +71,3 @@
> +    GstEGLContext * eglcontext);
> +gboolean gst_context_get_egl_context (GstContext * context,
> +    GstEGLContext ** eglcontext);
> 
> I don't think an EGLContext should be distributed via GstContext. Why would you
> want to do that? Every element should probably have its own

Here the reason was to "mimic" what is done for GstGLDisplay. So I'll remove it
then. 
I do not know yet how GstContext works exactly. This is how gst-omx retrieve
the display right ? Wellout of the purpose of this bug/ticket, even if "Every
element should probably have its own", would it be a way to share glcontexts
together ?

> 
> @@ +92,3 @@
> +
> +EGLConfig gst_egl_display_get_config (GstEGLDisplay * display);
> +void gst_egl_display_set_config (GstEGLDisplay * display, EGLConfig config);
> 
> As said above, no GObject-like EGL bindings. People can just call EGL API
> themselves.

Ok I did it that because I removed GstEglGlesRenderContext. And I replaced it
with GstEGLContext. Then naturally config went do display. 

Well I'll submit an other solution that does not need to delete
GstEglGlesRenderContext, so that does not need to have GstEGLContext. But I
would need this:

EGLContext gst_egl_adaptation_context_get_eglcontext (GstEglAdaptationContext *
ctx)
{
  return ctx->eglglesctx->eglcontext;
}

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.