[Bug 706509] mp4mux: add ftyp and extra atoms to the streamheaders

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=706509
  GStreamer | gst-plugins-good | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #253149|none                        |needs-work
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-08-27 08:39:56 UTC ---
Review of attachment 253149:
 --> (https://bugzilla.gnome.org/review?bug=706509&attachment=253149)

Now the only problem I see here is that it breaks ABI. Some code might assume
that it gets a single buffer as qtmux streamheaders... now it would get an
array. Not sure how relevant that is.

::: gst/isomp4/gstqtmux.c
@@ +1619,3 @@
+    gst_value_array_append_value (&array, &value);
+    g_value_unset (&value);
+  }

Shouldn't all three always be available when this is called? Maybe add an
assertion for that?

@@ +2006,3 @@
     /* no need to seek back */
+    ret = gst_qt_mux_send_moov (qtmux, NULL, FALSE);
+    gst_qt_mux_set_header_on_caps (qtmux);

First set caps, then push buffers

@@ +2094,3 @@
     return ret;

+  gst_qt_mux_set_header_on_caps (qtmux);

Why is this required here too?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.