[Bug 706054] move GstEGLImageBufferPool and allocator from eglglessink to gstegl lib

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=706054
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #253109|none                        |needs-work
             status|                            |

--- Comment #14 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-08-27 08:50:11 UTC ---
Review of attachment 253109:
 --> (https://bugzilla.gnome.org/review?bug=706054&attachment=253109)

::: ext/eglgles/gstegladaptation_egl.c
@@ +839,3 @@
 mem_error:
   {
+    GST_ERROR_OBJECT (GST_CAT_DEFAULT, "Failed to create EGLImage");

This will crash, make it GST_ERROR("Failed ...") instead.

::: ext/eglgles/gsteglglessink.c
@@ +539,3 @@
+            (eglglessink->pool)->allocator, eglglessink->egl_context->display,
+            gst_egl_adaptation_context_get_egl_context
+            (eglglessink->egl_context), format, width, height);

This is only valid for EGL anyway, having this code here for EAGL will break
compilation (and already does before your changes). So no need to add the new
function

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.