[Bug 706957] Support for AAC in bluez avdtpsrc

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=706957
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #253346|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-08-28 09:10:16 UTC ---
Review of attachment 253346:
 --> (https://bugzilla.gnome.org/review?bug=706957&attachment=253346)

::: sys/bluez/a2dp-codecs.h
@@ +110,3 @@
+
+#define AAC_CHANNELS_1        0x02
+#define AAC_CHANNELS_2        0x01

Seriously? Not more than 2 channels are supported?

@@ +126,1 @@
 } __attribute__ ((packed)) a2dp_sbc_t;

Please don't run gst-indent on headers

::: sys/bluez/gstavdtputil.c
@@ +634,3 @@
+
+  structure = gst_structure_new_empty ("audio/mpeg");
+  value = g_new0 (GValue, 1);

Allocate that on the stack: GValue value = G_VALUE_INIT; g_value_init (&value,
G_TYPE_INT);

@@ +661,3 @@
+
+  /* base-profile */
+  list = g_value_init (g_new0 (GValue, 1), GST_TYPE_LIST);

Also allocate on the stack

@@ +685,3 @@
+
+  /* rate */
+  list = g_value_init (g_new0 (GValue, 1), GST_TYPE_LIST);

And this

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.