[Bug 707039] New: Remove manual initialization of videoinfo in gst_v4l2_object_get_caps_info()
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Thu Aug 29 04:11:49 PDT 2013
https://bugzilla.gnome.org/show_bug.cgi?id=707039
GStreamer | gst-plugins-good | 1.0.10
Summary: Remove manual initialization of videoinfo in
gst_v4l2_object_get_caps_info()
Classification: Platform
Product: GStreamer
Version: 1.0.10
OS/Version: Linux
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: gst-plugins-good
AssignedTo: gstreamer-bugs at lists.freedesktop.org
ReportedBy: visechelle at gmail.com
QAContact: gstreamer-bugs at lists.freedesktop.org
GNOME version: ---
Created an attachment (id=253485)
View: https://bugzilla.gnome.org/attachment.cgi?id=253485
Review: https://bugzilla.gnome.org/review?bug=707039&attachment=253485
Patch
In gst_v4l2_object_get_caps_info() of gstv4l2object.c, videoinfo is initialized
with gst_video_info_from_caps() only for video/x-raw. This leads to have a
video format set to GST_VIDEO_FORMAT_UNKNOWN whereas it should be set to
GST_VIDEO_FORMAT_ENCODED for compressed videos.
This also means that the condition "stride != obj->bytesperline" in
gst_v4l2_buffer_pool_set_config() of gstv4l2bufferpool.c will be checked and
this might failed as some drivers output something different than 0 (as
explained in commit log 1ed4239ea7ce2f5eda5a8f7029a718f42f06c155).
See the patch provided as a possible solution.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list