[Bug 707032] qtdemux: add support for webvtt subtitles

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=707032
  GStreamer | gst-plugins-good | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #253490|none                        |reviewed
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-08-29 12:15:08 UTC ---
Review of attachment 253490:
 --> (https://bugzilla.gnome.org/review?bug=707032&attachment=253490)

::: gst/isomp4/qtdemux.c
@@ +3910,3 @@
   if (G_UNLIKELY (stream->subtype != FOURCC_text
+          && stream->subtype != FOURCC_sbtl &&
+          stream->subtype != FOURCC_wvtt)) {

Maybe it's time for a is_subtitle_fourcc() macro?

@@ +10769,3 @@
+    case GST_MAKE_FOURCC ('w', 'v', 't', 't'):
+      _codec ("WebVTT subtitle");
+      caps = gst_caps_new_empty_simple ("application/x-subtitle");

I'd prefer subtitle/x-webvtt :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.