[Bug 719684] New: [GstVideoDecoder] allocation query is always at least sent twice

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=719684
  GStreamer | gst-plugins-base | git

           Summary: [GstVideoDecoder] allocation query is always at least
                    sent twice
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: julien.isorce at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=263299)
 View: https://bugzilla.gnome.org/attachment.cgi?id=263299
 Review: https://bugzilla.gnome.org/review?bug=719684&attachment=263299

gstvideodecoder: clear GST_PAD_FLAG_NEED_RECONFIGURE flag if
gst_video_decoder_negotiate succeeds

* I noticed that GstVideoDecoder::gst_video_decoder_negotiate does not clear
the GST_PAD_FLAG_NEED_RECONFIGURE flag when it succeeds.

It causes the decoder to negotiate again, so query allocation is done twice.
(the second
time in gst_video_decoder_allocate_output_frame), even if the first negotiation
succeeded.

* steps to reproduce:

gst-launch-1.0 v4l2src io-mode=mmap ! jpegdec ! xvimagesink

Since recently it seems that a pad is initially marked to
GST_PAD_FLAG_NEED_RECONFIGURE : 
http://cgit.freedesktop.org/gstreamer/gstreamer/commit/gst/gstpad.c?id=c279bdb663de532be58b31970b26ff515ff4f098

* other informations: the negotiation design
http://cgit.freedesktop.org/gstreamer/gstreamer/tree/docs/design/part-negotiation.txt

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.