[Bug 719849] [PLUGIN-MOVE] move mpg123 to -ugly

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Dec 4 13:55:19 PST 2013


https://bugzilla.gnome.org/show_bug.cgi?id=719849
  GStreamer | gst-plugins-bad | git

Olivier Crete (Tester) <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olivier.crete at ocrete.ca

--- Comment #3 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2013-12-04 21:55:11 UTC ---
Partial review:

- gst_pad_get_allowed_caps() can return NULL if thepad is not linked, check for
null value, example: gst-launch-1.0 filesrc location=file.mp3 ! mpegaudioparse
! mpg123audiodec

- In more than one place, it return GST_FLOW_ERROR without doing
GST_ELEMENT_ERROR(), ie without posting an error message

- parsed=true shouldn't be in the static caps, otherwise it fails strangely
without a parser. May want to check if parsed=true in set_format too.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list