[Bug 711620] Create a temporary file during FTP transfer/upload

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=711620
  GStreamer | gst-plugins-bad | git

Olivier Crete (Tester) <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #259266|none                        |needs-work
             status|                            |

--- Comment #6 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2013-12-06 00:13:48 UTC ---
Review of attachment 259266:
 --> (https://bugzilla.gnome.org/review?bug=711620&attachment=259266)

::: ext/curl/gstcurlftpsink.c
@@ +139,3 @@
+  g_object_class_install_property (gobject_class, PROP_CREATE_TEMP_FILE,
+      g_param_spec_boolean ("create-tmpfile", "Enable or disable temporary
file transfer",
+          "Creating a temporary file ensures a proper file transfer",

Might benefit from something more descriptive like "Upload to a temporary file
then replace the original file"

@@ +197,3 @@
+        tmpfile_name = g_strdup_printf ("%s", sink->tmpfile_name);
+    } else {
+        tmpfile_name = g_strdup_printf ("%s", UPLOAD_FILE_AS);

Might be better to have something random as the default ? Along the files of
rename_to + ".tmp.%04%04X", g_random_int(), g_random_int()

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.