[Bug 720813] New: descriptors.c:89: possible constant expression ?

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=720813
  GStreamer | gst-plugins-good | 0.10.31

           Summary: descriptors.c:89: possible constant expression ?
    Classification: Platform
           Product: GStreamer
           Version: 0.10.31
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: dcb314 at hotmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


I just ran the static analyser "cppcheck" over the source code
of gst-plugins-good-0.10.31.

It said many things, including

[descriptors.c:89]: (style) Expression '(X & 0x80) == 0x1' is always false.

Source code is

    next = ((ptr[index] & 0x80) == 1);

Suggest code rework.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.