[Bug 704321] Add complete support for GstContext

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=704321
  GStreamer | gst-plugins-gl | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #259714|none                        |needs-work
             status|                            |

--- Comment #31 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-12-27 10:40:36 UTC ---
Review of attachment 259714:
 --> (https://bugzilla.gnome.org/review?bug=704321&attachment=259714)

Those comments apply to all files you changed, didn't repeat them for each

::: gst-libs/gst/gl/gstglfilter.c
@@ +805,3 @@
+      GST_GL_TYPE_CONTEXT, filter->context, NULL);
+  gst_query_add_allocation_meta (query,
+      GST_VIDEO_GL_TEXTURE_UPLOAD_META_API_TYPE, gl_context);

I think we should not abuse the GstVideoGLTextureUploadMeta for that but add
our own meta

@@ +869,3 @@
+  if (gst_query_find_allocation_meta (query,
+          GST_VIDEO_GL_TEXTURE_UPLOAD_META_API_TYPE, &idx)) {
+    GstContext *context;

It's a GstGLContext, not a GstContext :)

::: gst/gl/gstglimagesink.c
@@ +836,3 @@
   gboolean need_pool;
+  GError *error = NULL;
+  const GstStructure *gl_context;

Remove the const

@@ +902,3 @@
+  gst_query_add_allocation_meta (query,
+      GST_VIDEO_GL_TEXTURE_UPLOAD_META_API_TYPE, gl_context);
+  gst_structure_free ((GstStructure *) gl_context);

And here remove the cast

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.