[Bug 721078] mfcdec: fails to negotiate

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Dec 30 01:38:15 PST 2013


https://bugzilla.gnome.org/show_bug.cgi?id=721078
  GStreamer | gst-plugins-bad | 1.2.1

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-12-30 09:37:48 UTC ---
(In reply to comment #6)

> > I don't think this is correct, what negotiate() was doing should still be done
> > whenever GstVideoDecoder::negotiate() is called
> 
> but what is done in negotiate() (.i.e. "gst_mfc_dec_negotiate") is mainly to
> call "gst_video_decoder_set_output_state". Whereas there is a
> "g_return_val_if_fail (decoder->priv->output_state, FALSE);" in
> "gst_video_decoder_negotiate". So that's a bit contradictious :)

Maybe the g_return_val_if_fail() should be in default_negotiate() instead of
where it is now. That would make more sense to me at least

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list