[Bug 692045] Port uvch264src to gstreamer 1.0

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sat Feb 2 05:14:47 PST 2013


https://bugzilla.gnome.org/show_bug.cgi?id=692045
  GStreamer | gst-plugins-bad | git

--- Comment #6 from Sjoerd Simons <sjoerd at luon.net> 2013-02-02 13:14:43 UTC ---
(In reply to comment #3)
> You removed image/jpeg from the caps.
> 
> Any reason you use gst_memory_copy() instead of gst_memory_shared() in the
> mjpeg demuxer ?

gst_memory_shared asserts the GstMemory doens't have GST_MEMORY_FLAG_NO_SHARE,,
which v4l2src sets.. So sharing isn't possible in practise here.

In theory sharing if possible would be nice (ideally gst should get some api to
do this)

> I don't think droping segment events is required anymore.

I'm not entirely sure about the segment handling, so i left it as is.. Youness
might be able to clarify what it's necessary in 0.10

> In the src, you replaced gst_pad_fixate_caps(), with gst_caps_fixate()..
> v4l2src actually has code in there, so it may make more sense to call
> gst_base_src_fixate(v4l2src, caps);

Maybe, but that's not public api currently (and i don't think banging on the
vmethod by hand is very nice :))

Ideally one might at some point want to merge the v4l specific bits into
v4l2src such that the bin doesn't have to bang ioctls on the device behind
v4l2src back (and merge the caps negotiation back into v4l2src as well) 

> The getcaps query handling should pass the filter caps around.

fixed in the git branch. Not tested as i don't have the camera with me :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list