[Bug 692045] Port uvch264src to gstreamer 1.0

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=692045
  GStreamer | gst-plugins-bad | git

--- Comment #7 from Sjoerd Simons <sjoerd at luon.net> 2013-02-03 11:43:50 UTC ---
(In reply to comment #5)
> Thanks Sjoerd and great job! :)
> Couple of comments :
> - I noticed a bug in the code, the 'nv12' pad has format=NV21 instead of NV12
> (same on 0.10 branch)

Fixed

> - The VF_CAPS also had image/jpeg which I don't think are in
> GST_VIDEO_FORMATS_ALL (so VID_CAPS also will be missing it)

fixed

> - In gst_uvc_h264_src_fixate_caps, why did you remove the gst_caps_unref(tcaps)
> ?

gst_caps_normalize takes ownership in 1.0

> - Same comment as Olivier about the gst_pad_fixate_caps

See my reply there :)

> - I didn't look at the changed in the mjpeg_demux_chain cause it looks scary :)

heh, it's fine don't worry.. :p

> - The custom_upstream "renegotiate" event handling should be removed and
> replaced with handling the reconfigure event (or is that automatic?).

Removed that code (nothing send the event atm). Making sure uvch264
renegotiates correctly is something todo, but given v4l2src can't renegotiate
properly atm it's a tad moot

> - In tests/examples/uvch264/window.glade, you forgot to change (fourcc) into
> (string) for the caps.
fixed

> - In
> http://cgit.collabora.com/git/user/sjoerd/gst-plugins-bad.git/commit/?h=uvch264&id=d9c64a61634070d50314bf61c6018c965ea97f0b
> you changed the section name but didn't change it in the docs/ file so it gets
> picked up by gtk-doc.
> 
> That's about it from my side, but this is my first 1.0 code that I've looked at
> so I might not be as qualified.

You had some good catches so i guess you are :)

> 
> There is also a couple of bugfixes I've done recently on the 0.10 branch :
> http://cgit.collabora.com/git/user/kakaroto/gst-plugins-bad.git/log/?h=0.10
> You can ignore the PropertyProbe patch (until we have an equivalent for 1.0),
> but there were a couple of bugs in transform_caps and handling of the caps ref
> that might need porting to the 1.0 code.

>From just a quick skim it looks like it's only the refcounting bug that isn't
pulled in yet (which changed in 1.0, but i should doublecheck if it's correct
there).  or did i miss something?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.