[Bug 693481] gst-launch: Use signalfd() to handle keyboard interruption
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Sat Feb 9 08:42:37 PST 2013
https://bugzilla.gnome.org/show_bug.cgi?id=693481
GStreamer | gstreamer (core) | git
--- Comment #1 from krzysztof.konopko at youview.com 2013-02-09 16:42:31 UTC ---
I don't understand the logic behind waiting_eos. By default it's FALSE so if a
signal handler is invoked, it'll deregister itself (sigint_restore()). If -e
option is used, setting waiting_eos to TRUE makes little sense as the signal
handler is already restored to the default one and will not be invoked any
more.
In the proposed patch I set waiting_eos to TRUE by default as this is what we
naturally expect to happen. I feel uneasy about it though as there is of
course a number of error conditions and at some point for the sake of diligence
SIGINT handler should be deregistered once we know there'll be no bus activity
expected any more.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list