[Bug 690639] pngdec: decoded frames are not pushed out

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=690639
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #234696|none                        |accepted-commit_now
             status|                            |

--- Comment #9 from Sebastian Dröge <slomo at circular-chaos.org> 2013-02-11 11:34:52 UTC ---
Review of attachment 234696:
 --> (https://bugzilla.gnome.org/review?bug=690639&attachment=234696)

Looks good after a short look

::: gst/videoparsers/gstpngparse.c
@@ +108,3 @@
+    goto beach;
+
+  if (startcode != G_GUINT64_CONSTANT (0x89504E470D0A1A0A)) {

Maybe use constants for this?

@@ +125,3 @@
+        goto beach;
+
+      if (startcode == G_GUINT64_CONSTANT (0x89504E470D0A1A0A)) {

...and this

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.