[Bug 693587] New: Adding offset to GstSegment deserialize/serialize to fix jump on uninitialized value

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=693587
  GStreamer | gstreamer (core) | git

           Summary: Adding offset to GstSegment deserialize/serialize to
                    fix jump on uninitialized value
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: gnome at mithis.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=235699)
 View: https://bugzilla.gnome.org/attachment.cgi?id=235699
 Review: https://bugzilla.gnome.org/review?bug=693587&attachment=235699

Patch to fix the problem.

gstvalue: Adding offset to GstSegment serialize/deserialize.

    Fixed valgrind complaining about the following uninitialised jump;
    ==25529== Conditional jump or move depends on uninitialised value(s)
    ==25529==    at 0x4EB2B69: gst_segment_to_running_time (gstsegment.c:484)
    ==25529==    by 0x85AF802: gst_base_sink_get_sync_times
(gstbasesink.c:1912)
    ==25529==    by 0x85B853F: gst_base_sink_do_sync (gstbasesink.c:2372)
    ==25529==    by 0x85B96D5: gst_base_sink_chain_unlocked.isra.11
(gstbasesink.c:3301)
    ==25529==    by 0x85BADAB: gst_base_sink_chain_main (gstbasesink.c:3446)
    ==25529==    by 0x4E93358: gst_pad_push_data (gstpad.c:3655)
    ==25529==    by 0xA8EBDF6: gst_gdp_depay_chain (gstgdpdepay.c:330)
    ==25529==    by 0x4E93358: gst_pad_push_data (gstpad.c:3655)
    ==25529==    by 0x85BFFCF: gst_base_src_loop (gstbasesrc.c:2723)
    ==25529==    by 0x4EC0DAE: gst_task_func (gsttask.c:316)
    ==25529==    by 0x5731247: g_thread_pool_thread_proxy (gthreadpool.c:309)
    ==25529==    by 0x57309E4: g_thread_proxy (gthread.c:801)
    ==25529==    by 0x59C3E99: start_thread (pthread_create.c:308)
    ==25529==    by 0x5CCCCBC: clone (clone.S:112)
    ==25529==  Uninitialised value was created by a stack allocation
    ==25529==    at 0x4ED172F: gst_value_deserialize (gstvalue.c:4900)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.