[Bug 693665] eglglessink: add support for Raspberry Pi

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=693665
  GStreamer | gst-plugins-bad | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #235800|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge <slomo at circular-chaos.org> 2013-02-12 18:09:23 UTC ---
Review of attachment 235800:
 --> (https://bugzilla.gnome.org/review?bug=693665&attachment=235800)

::: configure.ac
@@ +1720,3 @@
+      AC_CHECK_HEADER(bcm_host.h, [
+        HAVE_EGLGLES="yes"
+        EGLGLES_LIBS="-lGLESv2 -lEGL -lbcm_host"

You should add checks for the libraries too, similar to what is done for Mali

::: ext/eglgles/gsteglglessink.c
@@ +1544,3 @@
+  GST_DEBUG_OBJECT (eglglessink, "Initialize BCM host");
+  bcm_host_init ();
+#endif

I think this should just be in plugin_init()

@@ +1553,3 @@
+  }
+#else
+  if (!eglMakeCurrent (1, EGL_NO_SURFACE, EGL_NO_SURFACE, EGL_NO_CONTEXT)) {

Why is this necessary? Please add a comment

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.