[Bug 693665] eglglessink: add support for Raspberry Pi

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=693665
  GStreamer | gst-plugins-bad | git

--- Comment #3 from Julian Scheel <julian at jusst.de> 2013-02-12 19:55:24 UTC ---
(In reply to comment #1)
> Review of attachment 235800 [details]:
> 
> ::: configure.ac
> @@ +1720,3 @@
> +      AC_CHECK_HEADER(bcm_host.h, [
> +        HAVE_EGLGLES="yes"
> +        EGLGLES_LIBS="-lGLESv2 -lEGL -lbcm_host"
> 
> You should add checks for the libraries too, similar to what is done for Mali

Will try to add some.

> ::: ext/eglgles/gsteglglessink.c
> @@ +1544,3 @@
> +  GST_DEBUG_OBJECT (eglglessink, "Initialize BCM host");
> +  bcm_host_init ();
> +#endif
> 
> I think this should just be in plugin_init()

Agreed, I will move it there.

> @@ +1553,3 @@
> +  }
> +#else
> +  if (!eglMakeCurrent (1, EGL_NO_SURFACE, EGL_NO_SURFACE, EGL_NO_CONTEXT)) {
> 
> Why is this necessary? Please add a comment

Yes, actually when eglMakeCurrent is not called the eglGetDisplay call causes
heap corruption. See this bug in rpi firmware
https://github.com/raspberrypi/firmware/issues/99. I think hardcoding to 1 was
the only way I could get this to work, but I will double check.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.