[Bug 693481] gst-launch: Use signalfd() to handle keyboard interruption

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=693481
  GStreamer | gstreamer (core) | git

Krzysztof Konopko <krzysztof.konopko+bugzilla.gnome> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #235588|0                           |1
        is obsolete|                            |

--- Comment #4 from Krzysztof Konopko <krzysztof.konopko+bugzilla.gnome at gmail.com> 2013-02-13 00:33:32 UTC ---
Created an attachment (id=235842)
 View: https://bugzilla.gnome.org/attachment.cgi?id=235842
 Review: https://bugzilla.gnome.org/review?bug=693481&attachment=235842

A new patch that rips out raw signal handling and uses g_source_set_callback()
instead

Indeed, g_source_set_callback() seems like an elegant approach.  Although it
internally uses a traditional signal handler, it does the dirty job of
dispatching GSource handler from the GMainContext in a safe manner.

It'd be nice to do some research and re-plumbing of this area in GLib to use
signalfd() but from the GStreamer perspective it's an implementation detail and
not a concern.

Please have a look and let me know what you think.

Cheers,
Kris

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.