[Bug 693481] gst-launch: Use signalfd() to handle keyboard interruption

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=693481
  GStreamer | gstreamer (core) | git

--- Comment #7 from Krzysztof Konopko <krzysztof.konopko+bugzilla.gnome at gmail.com> 2013-02-13 15:17:29 UTC ---
(In reply to comment #6)
> Review of attachment 235842 [details]:
> 
> ::: tools/gst-launch.c
> @@ +38,3 @@
>  #endif
>  #ifndef DISABLE_FAULT_HANDLER
> +#include <glib-unix.h>
> 
> Will this block only be used on Unix-like platforms?

Yes:

/* FIXME: hack alert */                                                         
#ifdef HAVE_WIN32
#define DISABLE_FAULT_HANDLER
#endif

Do you think it'd be a good idea to tidy this up (and SA_SIGINFO) by using
autotools?  Feels like both of them can be checked in configure.ac.

> 
> @@ +517,3 @@
> +      gst_message_new_application (GST_OBJECT (pipeline),
> +          gst_structure_new ("GstLaunchInterrupt",
> +              "message", G_TYPE_STRING, "Pipeline interrupted", NULL)));
> 
> As the signal handler is now called from the main loop you don't need to use
> this message anymore and can do what happens during the handling of the message
> here already.

I can't see any other way of exiting event_loop nicely other than posting a
message.  event_loop is entered (tried) several times.  Any suggestions?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.