[Bug 693481] gst-launch: Use signalfd() to handle keyboard interruption

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=693481
  GStreamer | gstreamer (core) | git

--- Comment #9 from Krzysztof Konopko <krzysztof.konopko+bugzilla.gnome at gmail.com> 2013-02-13 20:00:30 UTC ---
(In reply to comment #8)
> > Do you think it'd be a good idea to tidy this up (and SA_SIGINFO) by using
> > autotools?  Feels like both of them can be checked in configure.ac.
> 
> Sorry, what exactly do you want to check in configure.ac.
> 

Whether SA_SIGINFO flag is supported on a given platform.  I can check in repo
history what the original concerns were but I wanted to know if you have any
strong feelings about it. 

> From a maintenance perspective I'd like to get rid of as much code as possible,
> esp. platform-specific code, and avoid configure checks wherever possible.

I'm the right guy to delete code.  I love deleting code (not sure if more than
writing it ;)) Sometimes I happen to delete too much so I solicit about code
deletion in the first place.  Good to know you'd like to get rid of as much
code as you can :)

> The
> system headers are already checked for though  (HAVE_FOO_BAR_H in config.h).

The thing is that I was wondering if some configure tests are missing but I
guess the right thing to do is simply to get rid of SA_SIGINFO altogether as
there's not much use of it other than printing some diagnostic info.

> glib-unix.h should be used in case of #ifdef G_OS_UNIX (which should hopefully
> also be set on cygwin).

Oh, great.  I didn't know that (as I'm not a glib guru... and not guru at all
:)).

> siginfo/action stuff should go away if we use the GLib
> API, no?

I guess for SIGSEGV and SIGQUIT the old school signal handling code has to stay
to keep the nice feature that enables attaching a debugger to a spinning
process that is about to die.  GLib API doesn't support these signals.  Unless
you think otherwise.

> Don't know if that answers your question :)
Hm... sort of.  I'll try to do the right thing and we'll see how it goes with a
next patch.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.