[Bug 693401] gstdecodebin2 doesn't set send event on pad before exposing pad

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Feb 14 01:04:37 PST 2013


https://bugzilla.gnome.org/show_bug.cgi?id=693401
  GStreamer | gst-plugins-base | 1.x

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #235968|none                        |needs-work
             status|                            |

--- Comment #6 from Sebastian Dröge <slomo at circular-chaos.org> 2013-02-14 09:04:34 UTC ---
Review of attachment 235968:
 --> (https://bugzilla.gnome.org/review?bug=693401&attachment=235968)

::: gst/playback/gstdecodebin2.c
@@ +3132,3 @@
 beach:
+  if (G_IS_VALUE (&item))
+    g_value_unset (&item);

Why this?

@@ +3898,3 @@
       gst_pad_push_event (GST_PAD_CAST (dpad),
           gst_event_ref (GST_PAD_PROBE_INFO_EVENT (info)));
+      return GST_PAD_PROBE_PASS;

Yes, just re-add the old code that was removed by the old patch

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list