[Bug 693826] dmabuf-based GstMemory and GstAllocator incl. v4l2src support

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=693826
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #236578|none                        |needs-work
             status|                            |

--- Comment #21 from Sebastian Dröge <slomo at circular-chaos.org> 2013-02-19 09:12:58 UTC ---
Review of attachment 236578:
 --> (https://bugzilla.gnome.org/review?bug=693826&attachment=236578)

::: configure.ac
@@ +582,3 @@
+# Check if v4l2 support dmabuf
+if test x$HAVE_GST_V4L2 = xyes; then
+    AC_CHECK_DECLS(V4L2_MEMORY_DMABUF,,,[

Can't you just check #ifdef V4L2_MEMORY_DMABUF inside the code?

::: sys/v4l2/gstv4l2bufferpool.c
@@ +206,3 @@
+
+        meta->vbuffer.memory = V4L2_MEMORY_DMABUF;
+        pool->allocator = gst_dmabuf_allocator_obtain ();

For every buffer you set a new allocator in the pool, increasing the refcount
once per buffer. The allocator should probably also be set in the buffer pool
config somehow

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.