[Bug 684339] shm: use SOCK_CLOEXEC where appropriate in shmpipe
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Thu Feb 28 09:44:49 PST 2013
https://bugzilla.gnome.org/show_bug.cgi?id=684339
GStreamer | gst-plugins-bad | 0.10.22
Olivier Crete (Tester) <olivier.crete> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
CC| |olivier.crete at ocrete.ca
Resolution| |FIXED
--- Comment #3 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2013-02-28 17:44:44 UTC ---
I pushed the patch for O_CLOEXEC, but I'm not convinced about the usefulness of
SOCK_CLOEXEC, because
1. you have to build against recent linux
2. you have to test at runtime if you're running against a recent enough kernel
(and fallback to fcntl anyway).
3. fcntl isn't that expensive at all
commit c175c6b3d083f6bf3798cd172b38c4979b067c73
Author: Blake Tregre <blake at oblong.com>
Date: Thu Nov 8 13:22:41 2012 -0800
shm: use O_CLOEXEC where appropriate in shmpipe
https://bugzilla.gnome.org/show_bug.cgi?id=684339
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list