[Bug 689191] d3dvideosink improvements

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=689191
  GStreamer | gst-plugins-bad | 0.10.x

--- Comment #12 from David Hoyt <dhoyt at llnl.gov> 2013-01-10 09:35:14 UTC ---
Sebastian: While I'm at it, and I apologize for hijacking this thread, I saw
another commit 'remove scary "while (object.refcount > 0) release (object);"'
-- I agree that's scary but the reason for that being in there is due to the
fact that video card manufacturers actually implement part of the DirectX API
and some of their implementations are just plain buggy and they forget to
unreference causing a leak. It's not for covering up a logic error.

In an ideal world, I agree it's a bad idea. Perhaps it would be better to fail
fast instead of ignoring the problem and allowing the memory leak.

When the sink was first written I had to use it on systems that ran 24/7 for
years and so slow memory leaks over time become huge problems.

The original code was tried on several video cards over a few different
vendors. ATI cards were typically the worst offenders IIRC. And that hack
eliminated the leaks. Just my $0.02...

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.