[Bug 689809] osxvideosink: inconsistent keyboard navigation events

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=689809
  GStreamer | gst-plugins-good | 0.10.31

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #231031|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge <slomo at circular-chaos.org> 2013-01-16 10:42:43 UTC ---
Review of attachment 231031:
 --> (https://bugzilla.gnome.org/review?bug=689809&attachment=231031)

::: gst-plugins-good/sys/osxvideo/cocoawindow.m
@@ +91,3 @@
+
+static
+gchar* gst_keycode_to_keyname(gint16 keycode)

Could you change this to return a const gchar* (no g_strdup(), no g_free()
below).

Also is this going to work with combination key presses like ctrl+c? And are
you sure there is no function in OSX anywhere to do this conversion?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.