[Bug 663458] qtdemux: add support for LPCM QuickTime 7 uncompressed audio

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=663458
  GStreamer | gst-plugins-good | 0.10.x

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|1.1.x                       |1.1.1
            Summary|qtdemux: Does not support   |qtdemux: add support for
                   |LPCM audio                  |LPCM QuickTime 7
                   |                            |uncompressed audio

--- Comment #14 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2013-01-28 23:59:31 UTC ---
> I haven't looked too much into how the buffers are output yet from the demuxer,
> but I would suggest we merge my patches and close this bug and clone/open a new
> one about the 6 bytes buffers issue, as it's unrelated to LPCM support itself.

Agreed.


> With my fixes, transcoding the file actually fixes the sound issue but it took
> me 35 seconds to transcode the 12s audio from raw to mp3.

This works:

gst-launch-1.0 uridecodebin uri=file:///663458-lpcm.mov name=d  d. ! queue !
videoconvert ! xvimagesink   d. ! rndbuffersize min=6000 max=6000 !
audioconvert ! pulsesink


I've fixed up one of the commit messages a little to explain why qdm2 caps
parsing was disabled (which confused me at first when I saw the patch), and
added bug links to this bug:

commit f6a00ad6e9165ed3b59eba904cfbb8bbbee23495
Author: Youness Alaoui <youness.alaoui at collabora.co.uk>
Date:   Wed Jan 9 13:24:49 2013 -0500

    qtdemux: set interleaved layout correctly for LPCM audio

    https://bugzilla.gnome.org/show_bug.cgi?id=663458

commit a76524ea08ebc0322b11d9743733d3987b4793fd
Author: Youness Alaoui <youness.alaoui at collabora.co.uk>
Date:   Tue Jan 8 20:45:21 2013 -0500

    qtdemux: add support for LPCM fourcc (uncompressed audio in Quicktime7)

    https://bugzilla.gnome.org/show_bug.cgi?id=663458

commit 69b814546a65a3f62a733dae40c55ad90aab0b44
Author: Youness Alaoui <youness.alaoui at collabora.co.uk>
Date:   Tue Jan 8 20:42:35 2013 -0500

    qtdemux: print all debug for sound sample description v2

    https://bugzilla.gnome.org/show_bug.cgi?id=663458

commit 92ff8a9b09424101557824bb2a3c94939c61a8e0
Author: Youness Alaoui <youness.alaoui at collabora.co.uk>
Date:   Tue Jan 8 20:14:17 2013 -0500

    qtdemux: sound sample description v2 doesn't override samples_per_packet

    https://bugzilla.gnome.org/show_bug.cgi?id=663458

commit ee3d9cbd98d1c5e63251d87a061240b0b44eaa23
Author: Youness Alaoui <youness.alaoui at collabora.co.uk>
Date:   Tue Jan 8 19:57:50 2013 -0500

    qtdemux: pass stsd data to qtdemux_audio_caps()

    We will need that later for LPCM format support. Disable
    QDM2 parsing of stsd data which dead code before as well
    because data was always NULL.

    https://bugzilla.gnome.org/show_bug.cgi?id=663458

commit 6d3ff78575397ec714c7aa7d55ae86285a3efa85
Author: Youness Alaoui <youness.alaoui at collabora.co.uk>
Date:   Tue Jan 8 19:56:46 2013 -0500

    qtdemux: add len check for sound sample descriptions v1 and v2

    https://bugzilla.gnome.org/show_bug.cgi?id=663458

commit 629772f735902e81d511ba3c39821b7e178184db
Author: Tim-Philipp Müller <tim at centricular.net>
Date:   Mon Jan 28 22:42:25 2013 +0000

    rtpmanager: use C89-style comments



Thanks for the patches everyone!

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.