[Bug 692789] New: H264parse overwrites codec_data field before comparing old one and new one

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=692789
  GStreamer | gst-plugins-bad | 1.0.5

           Summary: H264parse overwrites codec_data field before comparing
                    old one and new one
    Classification: Platform
           Product: GStreamer
           Version: 1.0.5
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: visechelle at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


When parsing different H264 streams successively, h264parse overwrites
codec_data field in gst_h264_parse_set_caps() with the new codec_data from the
caps before the comparison done in gst_h264_parse_set_caps(). In my mind, the
line h264parse->codec_data = gst_buffer_ref (codec_data); in
gst_h264_parse_set_caps() is to be removed as first the old buffer is not unref
(potential memory leak), and codec_data field is correctly replace with the new
one from the caps in gst_h264_parse_set_caps(), after the comparison.
Because of this, codec_data from GstH264Parse structure and from the caps are
always the same. See the provided patch in attachment.

Cheers,

Paul HENRYS

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.