[Bug 664274] [API] codecparsers: add gst_mpeg_video_parse_slice() and gst_mpeg_video_parse_sequence_scalable_extension()

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=664274
  GStreamer | gst-plugins-bad | git

--- Comment #11 from Gwenole Beauchesne <gb.devel at gmail.com> 2013-01-29 13:36:44 UTC ---
Review of attachment 234723:
 --> (https://bugzilla.gnome.org/review?bug=664274&attachment=234723)

Hi,
- it seems that gst_mpeg_video_parse_slice_header() args are not vertically
aligned with the other functions;
- slice_vertical_position_extension is useless since it depends on seqhdr
values, i.e. it may not convey meaningful value from within the same data
structure;
- slice_picture_id has no comment on what it means;
- I really want header_size to be the last field with the following comment: /*
Size of the slice() header in bits */
- Missing leading space in /* Calculated values */
- I prefer mb_x, mb_y to mb_row, mb_column even if the latter comes from the
specs terminology.

Thanks,
Gwenole.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.