[Bug 664274] [API] codecparsers: add gst_mpeg_video_parse_slice() and gst_mpeg_video_parse_sequence_scalable_extension()

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=664274
  GStreamer | gst-plugins-bad | git

--- Comment #12 from sreerenj <bsreerenj at gmail.com> 2013-01-29 13:51:51 UTC ---
(In reply to comment #11)
> Review of attachment 234723 [details]:
> 
> Hi,
> - it seems that gst_mpeg_video_parse_slice_header() args are not vertically
> aligned with the other functions;

we need the start_code to get the type which is needed to calcuate
mb_x/mb_row..
otherwise we have to pass the slice_no as the next argument..(we already have 6
arguments :))

> - slice_vertical_position_extension is useless since it depends on seqhdr
> values, i.e. it may not convey meaningful value from within the same data
> structure;

have no objection to avoid that field :)

> - slice_picture_id has no comment on what it means;

just kept that field since it might need for some once else even though it is
not using for decoding.But i don't know whether someone is using that or
not...Is it an overhead?
As per the spec,

"slice_picture_id is intended to aid recovery on severe bursts of
errors for certain types of applications. For example, the application may
increment slice_picture_id with each transmitted picture, so that in case of
severe burst error, when several slices are lost, the decoder can know if the
slice following the burst error belongs to the current picture or to another
picture, which may be the case if at least a picture
header has been lost."


> - I really want header_size to be the last field with the following comment: /*
> Size of the slice() header in bits */

Sorry i didn't get it.Does the calculation is wrong? remember the data is
starting from the start_code.

> - Missing leading space in /* Calculated values */
> - I prefer mb_x, mb_y to mb_row, mb_column even if the latter comes from the
> specs terminology.

no objection .  

> Thanks,
> Gwenole.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.