[Bug 692933] [API] codecparsers: mpeg2: add new API that takes GstMpegVideoPacket arguments

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=692933
  GStreamer | gst-plugins-bad | unspecified

--- Comment #2 from Gwenole Beauchesne <gb.devel at gmail.com> 2013-01-31 12:55:43 UTC ---
(In reply to comment #1)
> Not entirely sure about the naming and order of arguments though (the
> inevitable bikeshedding, apologies): if the API is called
> gst_blah_packet_parse_foo() then the first argument should probably be the
> packet. That way bindings can map it to packet.parse_foo(). Or you make it
> gst_blah_parse_foo_from_packet(), then packet is the last arg.

I am not sure about the naming of the functions either. :)

(i) If we make it gst_mpeg_video_packet_parse_something(packet, hdr, ...), then
there could be cases where 1st arg (packet) is an input arg, second arg (the
parsed header) an output arg, and extra args as input. e.g. for the slice()
parser in particular, which requires an additional seqhdr for example.

(ii) If we make it gst_mpeg_video_parse_something_from_packet(), then this is
also fine but the names become very long.

I would be tempted by (i) + fixing up the args order, but I definitely have no
clear preference. Opinions?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.