[Bug 702988] gdkpixbufoverlay: crashes if any property changes during playback when location property is not set

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=702988
  GStreamer | gst-plugins-good | 1.0.7

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #247653|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge <slomo at circular-chaos.org> 2013-07-01 10:06:23 UTC ---
Review of attachment 247653:
 --> (https://bugzilla.gnome.org/review?bug=702988&attachment=247653)

::: ext/gdk_pixbuf/gstgdkpixbufoverlay.c
@@ +223,3 @@
       overlay->location = g_value_dup_string (value);
+      if (!gst_gdk_pixbuf_overlay_load_image (overlay, &err)) {
+        GST_ERROR_OBJECT (overlay, ("Could not load overlay image. %s",

This needs some locking, if we allow changing these things from properties you
need to protect all accesses everywhere to it with a mutex.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.